bingoss/owned-growth-engine
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Impact Reviewer reads GSC API and GA4 MCP evidence for trends #23

New issue
Closed
opened 2026-05-28 18:15:02 +01:00 by bingoss · 1 comment
bingoss commented 2026-05-28 18:15:02 +01:00
Owner
Copy link

What to build

Type: AFK.

Create the Impact Reviewer specialist path that reads performance evidence from the configured server-side GSC API and GA4 MCP. Local imports or exported files may remain as legacy fallback/test fixtures, but the intended product path is direct server-side tool access.

Acceptance criteria

  • Impact runs collect GSC API and GA4 MCP evidence through configured server access paths without storing secrets.
  • Metric snapshots and derived trend views are written for pages, queries, channels, published/draft outcomes where available, and recommended next steps.
  • Missing optional providers produce unknown/skipped diagnostics instead of invented performance conclusions.
  • Dashboard impact views show source/derived metrics and trend summaries without raw credential material or long payloads.
  • Tests are written first with deterministic seams for GSC API, GA4 MCP, provider unavailable, and malformed provider data.

Blocked by

None - can start immediately

## What to build Type: AFK. Create the Impact Reviewer specialist path that reads performance evidence from the configured server-side GSC API and GA4 MCP. Local imports or exported files may remain as legacy fallback/test fixtures, but the intended product path is direct server-side tool access. ## Acceptance criteria - [ ] Impact runs collect GSC API and GA4 MCP evidence through configured server access paths without storing secrets. - [ ] Metric snapshots and derived trend views are written for pages, queries, channels, published/draft outcomes where available, and recommended next steps. - [ ] Missing optional providers produce unknown/skipped diagnostics instead of invented performance conclusions. - [ ] Dashboard impact views show source/derived metrics and trend summaries without raw credential material or long payloads. - [ ] Tests are written first with deterministic seams for GSC API, GA4 MCP, provider unavailable, and malformed provider data. ## Blocked by None - can start immediately
bingoss commented 2026-05-29 09:20:43 +01:00
Author
Owner
Copy link

Issue #23 completion audit

Implemented and verified:

  • Added the Impact Reviewer worker path for implementation_verification requests that explicitly ask for impact_review evidence.
  • Collected required GSC API and GA4 MCP provider evidence through injectable/default provider adapters and persisted page/query/channel/outcome metric snapshots.
  • Added derived trend metrics from provider snapshots, including source references, trend summaries, outcome summaries, and recommended next steps.
  • Recorded provider diagnostics for configured, skipped, failed, and unavailable states without inventing metrics when optional providers are unavailable.
  • Failed malformed required provider payloads closed with safe diagnostics and no partial metric rows.
  • Updated the impact dashboard to expose safe trend summaries and next steps from the latest impact review stage without leaking raw provider payloads.

Acceptance criteria audit:

  • GSC API and GA4 MCP measurements are captured before/after go-live where provider data is available: met via metric_snapshots source rows keyed by observed dates, pages, queries, channels, and outcomes.
  • Dashboard shows safe impact evidence and decision-ready summaries: met via dashboard_impact trend_summaries, next_steps, provider_diagnostics, and metric snapshot data with raw payloads excluded.
  • Optional unavailable providers are skipped explicitly without fabricated evidence: met and covered by tests.
  • Required malformed provider data fails closed without partial persistence: met and covered by tests.
  • Tests were written first and then made green: met.

Tests run on codex-server:

  • python3 -m unittest tests.test_impact_reviewer_worker tests.test_postgres_dashboard.PostgresDashboardOverviewTests.test_impact_dashboard_returns_metric_snapshots_without_raw_measurement_payloads
  • Result: 5 tests passed.
  • python3 -m unittest tests.test_impact_reviewer_worker tests.test_postgres_dashboard tests.test_growth_orchestrator_worker tests.test_technical_audit_worker tests.test_keyword_competitor_worker tests.test_visibility_worker tests.test_business_profile_worker tests.test_public_listening_worker tests.test_authority_research_worker && git diff --check
  • Result: 92 tests passed; git diff --check passed.
Issue #23 completion audit Implemented and verified: - Added the Impact Reviewer worker path for implementation_verification requests that explicitly ask for impact_review evidence. - Collected required GSC API and GA4 MCP provider evidence through injectable/default provider adapters and persisted page/query/channel/outcome metric snapshots. - Added derived trend metrics from provider snapshots, including source references, trend summaries, outcome summaries, and recommended next steps. - Recorded provider diagnostics for configured, skipped, failed, and unavailable states without inventing metrics when optional providers are unavailable. - Failed malformed required provider payloads closed with safe diagnostics and no partial metric rows. - Updated the impact dashboard to expose safe trend summaries and next steps from the latest impact review stage without leaking raw provider payloads. Acceptance criteria audit: - GSC API and GA4 MCP measurements are captured before/after go-live where provider data is available: met via metric_snapshots source rows keyed by observed dates, pages, queries, channels, and outcomes. - Dashboard shows safe impact evidence and decision-ready summaries: met via dashboard_impact trend_summaries, next_steps, provider_diagnostics, and metric snapshot data with raw payloads excluded. - Optional unavailable providers are skipped explicitly without fabricated evidence: met and covered by tests. - Required malformed provider data fails closed without partial persistence: met and covered by tests. - Tests were written first and then made green: met. Tests run on codex-server: - python3 -m unittest tests.test_impact_reviewer_worker tests.test_postgres_dashboard.PostgresDashboardOverviewTests.test_impact_dashboard_returns_metric_snapshots_without_raw_measurement_payloads - Result: 5 tests passed. - python3 -m unittest tests.test_impact_reviewer_worker tests.test_postgres_dashboard tests.test_growth_orchestrator_worker tests.test_technical_audit_worker tests.test_keyword_competitor_worker tests.test_visibility_worker tests.test_business_profile_worker tests.test_public_listening_worker tests.test_authority_research_worker && git diff --check - Result: 92 tests passed; git diff --check passed.
Commenting is not possible because the repository is archived.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
codex-token-write-test-1780004082
Temporary token write test; safe to delete.

No labels
codex-token-write-test-1780004082
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bingoss/owned-growth-engine#23
No description provided.